Open
Conversation
added 3 commits
December 13, 2020 19:31
Now loop and play once can have a starting frame set. Currently, loop goes back to the very beginning, not the starting frame, but that can be fixed if other behavior is desired. This should resolve issue Wicklets#280.
In the previous implementation, some bugs related to syncing occurred. They all should be fixed now; both syncing and non-syncing should work as expected, with a starting frame.
Now there are tests for the clip starting frame. I also updated tests that needed to be tweaked after the changes to the clip starting frame.
Contributor
Author
|
I see this hasn't been merged yet, and it's been about a month... is this missing anything, or do I just need to resolve the conflicts? I added tests that pass, is there anything else that's needed? Thank you! |
Member
|
Hey @sporklpony apologies as this was delayed by holiday events. I have not had a chance to review this PR yet and so it will likely be coming in on 1.20! |
Contributor
Author
|
Sounds good, please do let me know if anything comes up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting frame of clips can now be specified. Includes tests.